[Quilt-dev] config-cc patch

[Jean Delvare]

Hi John,

I would like to merge your config-cc patch into quilt. Here are a few
things I would like to see clarified or fixed before I do.

You add the following:

> +LDLIBS   :=  @LIBS@

but then use:

> +     $(CC) -o $@ $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) $^ $(LIBS)

It seems to me like there is a confusion between $(LDLIBS) and $(LIBS).
Or am I missing something?

BTW, why are you adding this:

> +$(LIB:%=lib/%) : $(LIB_SRC:%=lib/%)
> +     $(CC) -o $@ $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) $^ $(LIBS)

Isn't this the default rule already? It seems to work no differently for
me without it.

>  LIB_SRC :=   backup-files.c
> (...)
> -DIRT +=              lib/backup-files lib/backup-files.o
> +DIRT +=              lib/backup-files$(EXEEXT) $(LIB_SRC:%.c=%.o)

I think there is a bug here, shouldn't this be $(LIB_SRC:%.c=lib/%.o)?

I also don't quite understand this part. When compiling, no
lib/backup-files.o seems to be created. lib/backup-files.c is compiled
to lib/backup-files directly. So why do we mention lib/backup-files.o at
all?

How would we force the .o file to be generated if we wanted to?

As a side note, I noticed that we are compiling with -g by default.
Can't we change that? It doesn't seem correct to me.

Thanks,
-- 
Jean Delvare