[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qga: Allow building of the guest agent without system emulat
Re: [PATCH] qga: Allow building of the guest agent without system emulators or tools
Thu, 10 Nov 2022 10:57:27 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0
On 10/11/2022 10.49, Philippe Mathieu-Daudé wrote:
On 10/11/22 09:35, Thomas Huth wrote:
On 10/11/2022 06.49, Markus Armbruster wrote:
Philippe Mathieu-Daudé <email@example.com> writes:
On 9/11/22 18:37, Thomas Huth wrote:
If configuring with "--disable-system --disable-user --enable-guest-agent"
the linking currently fails with:
qga/qemu-ga.p/commands.c.o: In function `qmp_command_info':
reference to `qmp_command_name'
Let's make sure that we also compile and link the required files if
the system emulators have not been enabled.
Signed-off-by: Thomas Huth <firstname.lastname@example.org>
I wonder for how long this has been broken.
Should we add such a configuration to CI?
Some month ago, I'd say: Sure! ... but considering that gitlab now limits
the available CI minutes and that apparently nobody really cares about
this configuration (otherwise someone would have complained about this
earlier), I think it's not that important to have a separate CI test for
We could eventually add a job restricted to qemu-project CI (not in
The problem is: Who's going to create such jobs? Someone needs to write the
yaml stuff and test it first. And at least I pretty much lost motivation to
work on new yaml stuff, since this burns my private CI minutes (which I
rather need for my maintainer duties instead).
Re: [PATCH] qga: Allow building of the guest agent without system emulators or tools, Thomas Huth, 2022/11/10