Re: [PATCH] qga: Allow building of the guest agent without system emulators or tools

[Philippe Mathieu-Daudé]

On 10/11/22 09:35, Thomas Huth wrote:
> On 10/11/2022 06.49, Markus Armbruster wrote:
> > Philippe Mathieu-Daudé <philmd@linaro.org> writes:
> >
> > > On 9/11/22 18:37, Thomas Huth wrote:
> > > > If configuring with "--disable-system --disable-user 
> > > > --enable-guest-agent"
> > > > the linking currently fails with:
> > > >
> > > > qga/qemu-ga.p/commands.c.o: In function `qmp_command_info':
> > > > build/../../home/thuth/devel/qemu/qga/commands.c:70: undefined 
> > > > reference to `qmp_command_name'

> > > > Let's make sure that we also compile and link the required files if
> > > > the system emulators have not been enabled.
> > > >
> > > > Signed-off-by: Thomas Huth <thuth@redhat.com>
> >
> > I wonder for how long this has been broken.
> >
> > Should we add such a configuration to CI?
>
> Some month ago, I'd say: Sure! ... but considering that gitlab now 
> limits the available CI minutes and that apparently nobody really cares 
> about this configuration (otherwise someone would have complained about 
> this earlier), I think it's not that important to have a separate CI 
> test for this configuration.

We could eventually add a job restricted to qemu-project CI (not in
forks).