[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] vmstate-static-checker:remove this redundant return

From: Laurent Vivier
Subject: Re: [PATCH] vmstate-static-checker:remove this redundant return
Date: Sat, 22 Oct 2022 23:19:42 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1

Le 28/09/2022 à 11:03, dinglimin a écrit :
Jump statements, such as return and continue let you
change the default flow of program execution,
but jump statements that direct the control flow to
the original direction are just a waste of keystrokes.

Signed-off-by: dinglimin <dinglimin@cmss.chinamobile.com>
  scripts/vmstate-static-checker.py | 1 -
  1 file changed, 1 deletion(-)

diff --git a/scripts/vmstate-static-checker.py 
index b369388360..dfeee8231a 100755
--- a/scripts/vmstate-static-checker.py
+++ b/scripts/vmstate-static-checker.py
@@ -367,7 +367,6 @@ def check_machine_type(s, d):
      if s["Name"] != d["Name"]:
          print("Warning: checking incompatible machine types:", end=' ')
          print("\"" + s["Name"] + "\", \"" + d["Name"] + "\"")
-    return
def main():

Applied to my trivial-patches branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]