[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] vmstate-static-checker:remove this redundant return
From: |
John Snow |
Subject: |
Re: [PATCH] vmstate-static-checker:remove this redundant return |
Date: |
Thu, 13 Oct 2022 18:36:29 -0400 |
On Wed, Sep 28, 2022 at 5:06 AM dinglimin
<dinglimin@cmss.chinamobile.com> wrote:
>
> Jump statements, such as return and continue let you
> change the default flow of program execution,
> but jump statements that direct the control flow to
> the original direction are just a waste of keystrokes.
>
> Signed-off-by: dinglimin <dinglimin@cmss.chinamobile.com>
> ---
> scripts/vmstate-static-checker.py | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/scripts/vmstate-static-checker.py
> b/scripts/vmstate-static-checker.py
> index b369388360..dfeee8231a 100755
> --- a/scripts/vmstate-static-checker.py
> +++ b/scripts/vmstate-static-checker.py
> @@ -367,7 +367,6 @@ def check_machine_type(s, d):
> if s["Name"] != d["Name"]:
> print("Warning: checking incompatible machine types:", end=' ')
> print("\"" + s["Name"] + "\", \"" + d["Name"] + "\"")
> - return
>
>
> def main():
> --
> 2.30.0.windows.2
>
This can go through the trivial branch.
Reviewed-by: John Snow <jsnow@redhat.com>
- Re: [PATCH] vmstate-static-checker:remove this redundant return,
John Snow <=