Re: [PATCH 1/2] hw/display/vmware_vga: replace fprintf calls with trace events

[Philippe Mathieu-Daudé]

On 1/4/22 19:06, Carwyn Ellis wrote:
> Debug output was always being sent to STDERR.
> 
> This has been replaced with trace events.
> 
> Signed-off-by: Carwyn Ellis <carwynellis@gmail.com>
> ---
>  hw/display/trace-events |  3 +++
>  hw/display/vmware_vga.c | 22 ++++++++++------------
>  2 files changed, 13 insertions(+), 12 deletions(-)
> 
> diff --git a/hw/display/trace-events b/hw/display/trace-events
> index 3a7a2c957f..e1a0d2a88a 100644
> --- a/hw/display/trace-events
> +++ b/hw/display/trace-events
> @@ -21,6 +21,9 @@ vmware_palette_write(uint32_t index, uint32_t value) "index 
> %d, value 0x%x"
>  vmware_scratch_read(uint32_t index, uint32_t value) "index %d, value 0x%x"
>  vmware_scratch_write(uint32_t index, uint32_t value) "index %d, value 0x%x"
>  vmware_setmode(uint32_t w, uint32_t h, uint32_t bpp) "%dx%d @ %d bpp"
> +vmware_verify_rect_less_than_zero(const char *name, const char *param, int 
> x) "%s: %s was < 0 (%d)"
> +vmware_verify_rect_greater_than_bound(const char *name, const char *param, 
> int bound, int x) "%s: %s was > %d (%d)"
> +vmware_verify_rect_surface_bound_exceeded(const char *name, const char 
> *component, int bound, const char *param1, int value1, const char *param2, 
> int value2) "%s: %s > %d (%s: %d, %s, %d)"

"%s: %s > %d (%s: %d, %s: %d)", otherwise:

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>