[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] linux-user: Fix trivial build error on loongarch64 hosts

From: Richard Henderson
Subject: Re: [PATCH v2] linux-user: Fix trivial build error on loongarch64 hosts
Date: Tue, 4 Jan 2022 14:13:32 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0

On 1/4/22 1:50 PM, Philippe Mathieu-Daudé wrote:
When building using GCC 8.3.0 on loongarch64 (Loongnix) we get:

   In file included from ../linux-user/signal.c:33:
   ../linux-user/host/loongarch64/host-signal.h: In function 
   ../linux-user/host/loongarch64/host-signal.h:57:9: error: a label can only 
be part of a statement and a declaration is not a statement
          uint32_t sel = (insn >> 15) & 0b11111111111;

We don't use the 'sel' variable more than once, so drop it.

Meson output for the record:

   Host machine cpu family: loongarch64
   Host machine cpu: loongarch64
   C compiler for the host machine: cc (gcc 8.3.0 "cc (Loongnix 8.3.0-6.lnd.vec.27) 
   C linker for the host machine: cc ld.bfd 2.31.1-system

Fixes: ad812c3bd65 ("linux-user: Implement CPU-specific signal handler for 
loongarch64 hosts")
Reported-by: Song Gao<gaosong@loongson.cn>
Suggested-by: Song Gao<gaosong@loongson.cn>
Reviewed-by: WANG Xuerui<git@xen0n.name>
Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
  linux-user/host/loongarch64/host-signal.h | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]