Re: [PATCH v3 11/12] usb/hcd-ehci: Remove redundant statements

[Laurent Vivier]

Le 09/03/2020 à 13:52, Chenqun (kuhn) a écrit :
> 
>> -----Original Message-----
>> From: Laurent Vivier [mailto:address@hidden]
>> Sent: Monday, March 9, 2020 8:43 PM
>> To: Chenqun (kuhn) <address@hidden>; qemu-
>> address@hidden; address@hidden
>> Cc: address@hidden; Zhanghailiang
>> <address@hidden>; Gerd Hoffmann <address@hidden>;
>> Euler Robot <address@hidden>; Philippe Mathieu-Daudé
>> <address@hidden>
>> Subject: Re: [PATCH v3 11/12] usb/hcd-ehci: Remove redundant statements
>>
>> Le 02/03/2020 à 14:07, Chen Qun a écrit :
>>> The "again" assignment is meaningless before g_assert_not_reached.
>>> In addition, the break statements no longer needs to be after
>>> g_assert_not_reached.
>>>
>>> Clang static code analyzer show warning:
>>> hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read
>>>             again = -1;
>>>             ^       ~~
>>>
>>> Reported-by: Euler Robot <address@hidden>
>>> Signed-off-by: Chen Qun <address@hidden>
>>> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
>>> ---
>>> Cc: Gerd Hoffmann <address@hidden>
>>> Cc: Philippe Mathieu-Daudé <address@hidden>
>>> ---
>>>  hw/usb/hcd-ehci.c | 3 ---
>>>  1 file changed, 3 deletions(-)
>>>
>>> diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index
>>> 56ab2f457f..29d49c2d7e 100644
>>> --- a/hw/usb/hcd-ehci.c
>>> +++ b/hw/usb/hcd-ehci.c
>>> @@ -1301,7 +1301,6 @@ static void ehci_execute_complete(EHCIQueue *q)
>>>          /* should not be triggerable */
>>>          fprintf(stderr, "USB invalid response %d\n", p->packet.status);
>>>          g_assert_not_reached();
>>> -        break;
>>>      }
>>>
>>>      /* TODO check 4.12 for splits */
>>> @@ -2105,9 +2104,7 @@ static void ehci_advance_state(EHCIState *ehci,
>>> int async)
>>>
>>>          default:
>>>              fprintf(stderr, "Bad state!\n");
>>> -            again = -1;
>>>              g_assert_not_reached();
>>> -            break;
>>>          }
>>>
>>>          if (again < 0 || itd_count > 16) {
>>>
>>
>> Applied to my trivial-patches branch.
>>
> Hi, Laurent
> 
> Gerd has added a patch to the USB queue today.
> 
> https://patchwork.kernel.org/patch/11405615/
>

Ok, removing it from mine.

Thanks,
Laurent