Re: [PATCH v3 12/12] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups()

[Laurent Vivier]

Le 02/03/2020 à 14:07, Chen Qun a écrit :
> Clang static code analyzer show warning:
> monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read
>                 set = true;
>                 ^     ~~~~
> 
> Reported-by: Euler Robot <address@hidden>
> Signed-off-by: Chen Qun <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Cc: "Dr. David Alan Gilbert" <address@hidden>
> Cc: Philippe Mathieu-Daudé <address@hidden>
> 
> v1->v2: move the 'set' declaration to the for() statement(Base on Philippe's 
> suggestion).
> ---
>  monitor/hmp-cmds.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c
> index 53bc3f76c4..c6b0495822 100644
> --- a/monitor/hmp-cmds.c
> +++ b/monitor/hmp-cmds.c
> @@ -2808,7 +2808,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict 
> *qdict)
>      const char *name = qdict_get_str(qdict, "name");
>      uint8_t type = qdict_get_try_int(qdict, "type", 9);
>      Error *err = NULL;
> -    bool set = false;
>  
>      list = qmp_query_rocker_of_dpa_groups(name, type != 9, type, &err);
>      if (err != NULL) {
> @@ -2820,6 +2819,7 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDict 
> *qdict)
>  
>      for (g = list; g; g = g->next) {
>          RockerOfDpaGroup *group = g->value;
> +        bool set = false;
>  
>          monitor_printf(mon, "0x%08x", group->id);
>  
> @@ -2864,14 +2864,11 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const 
> QDict *qdict)
>  
>          if (group->has_set_eth_dst) {
>              if (!set) {
> -                set = true;
>                  monitor_printf(mon, " set");
>              }
>              monitor_printf(mon, " dst %s", group->set_eth_dst);
>          }
>  
> -        set = false;
> -
>          if (group->has_ttl_check && group->ttl_check) {
>              monitor_printf(mon, " check TTL");
>          }
> 

Applied to my trivial-patches branch.

Thanks,
Laurent