[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v1 29/59] cryptodev-vhost.c: remove unneeded 'err' label in c
From: |
Gonglei (Arei) |
Subject: |
RE: [PATCH v1 29/59] cryptodev-vhost.c: remove unneeded 'err' label in cryptodev_vhost_start |
Date: |
Tue, 7 Jan 2020 08:18:09 +0000 |
> -----Original Message-----
> From: Daniel Henrique Barboza [mailto:address@hidden]
> Sent: Tuesday, January 7, 2020 2:24 AM
> To: address@hidden
> Cc: address@hidden; Daniel Henrique Barboza
> <address@hidden>; Gonglei (Arei) <address@hidden>
> Subject: [PATCH v1 29/59] cryptodev-vhost.c: remove unneeded 'err' label in
> cryptodev_vhost_start
>
> 'err' can be replaced by 'return r'.
>
> CC: Gonglei <address@hidden>
> Signed-off-by: Daniel Henrique Barboza <address@hidden>
> ---
> backends/cryptodev-vhost.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Gonglei <address@hidden>
> diff --git a/backends/cryptodev-vhost.c b/backends/cryptodev-vhost.c index
> 8337c9a495..907ca21fa7 100644
> --- a/backends/cryptodev-vhost.c
> +++ b/backends/cryptodev-vhost.c
> @@ -201,7 +201,7 @@ int cryptodev_vhost_start(VirtIODevice *dev, int
> total_queues)
> r = k->set_guest_notifiers(qbus->parent, total_queues, true);
> if (r < 0) {
> error_report("error binding guest notifier: %d", -r);
> - goto err;
> + return r;
> }
>
> for (i = 0; i < total_queues; i++) { @@ -236,7 +236,7 @@ err_start:
> if (e < 0) {
> error_report("vhost guest notifier cleanup failed: %d", e);
> }
> -err:
> +
> return r;
> }
>
> --
> 2.24.1
- [PATCH v1 58/59] linux-user/syscall.c: remove unneeded labels, (continued)
- [PATCH v1 58/59] linux-user/syscall.c: remove unneeded labels, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 59/59] linux-user/vm86.c: remove unneeded label in do_vm86(), Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 05/59] ram.c: remove unneeded labels, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 14/59] block/file-posix.c: remove unneeded labels, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 25/59] block/vhdx.c: remove unneeded 'exit' labels, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 29/59] cryptodev-vhost.c: remove unneeded 'err' label in cryptodev_vhost_start, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 34/59] ipmi/ipmi_bt.c: remove unneeded label in ipmi_bt_handle_event, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 35/59] ipmi_bmc_extern.c: remove unneeded label in ipmi_bmc_extern_handle_command, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 37/59] s390x/event-facility.c: remove unneeded labels, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 40/59] hsb/hcd-ehci.c: remove unneeded labels, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 43/59] i386/amd_iommu.c: remove unneeded label in amdvi_int_remap_msi(), Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 50/59] rdma/rdma_backend.c: remove unneeded label in rdma_backend_init(), Daniel Henrique Barboza, 2020/01/06