[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 14/59] block/file-posix.c: remove unneeded labels
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH v1 14/59] block/file-posix.c: remove unneeded labels |
Date: |
Mon, 6 Jan 2020 15:23:40 -0300 |
'out' label from cdrom_probe_device() can be removed, and its
only instance replaced by 'return prio'.
In raw_co_create(), 'out' can be replaced by 'return -errno' in
the error condition it is being called.
CC: Kevin Wolf <address@hidden>
CC: address@hidden
Signed-off-by: Daniel Henrique Barboza <address@hidden>
---
block/file-posix.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/block/file-posix.c b/block/file-posix.c
index 1b805bd938..b1a6549806 100644
--- a/block/file-posix.c
+++ b/block/file-posix.c
@@ -2265,9 +2265,8 @@ raw_co_create(BlockdevCreateOptions *options, Error
**errp)
/* Create file */
fd = qemu_open(file_opts->filename, O_RDWR | O_CREAT | O_BINARY, 0644);
if (fd < 0) {
- result = -errno;
- error_setg_errno(errp, -result, "Could not create file");
- goto out;
+ error_setg_errno(errp, errno, "Could not create file");
+ return -errno;
}
/* Take permissions: We want to discard everything, so we need
@@ -2342,7 +2341,7 @@ out_close:
result = -errno;
error_setg_errno(errp, -result, "Could not close the new file");
}
-out:
+
return result;
}
@@ -3554,7 +3553,7 @@ static int cdrom_probe_device(const char *filename)
fd = qemu_open(filename, O_RDONLY | O_NONBLOCK);
if (fd < 0) {
- goto out;
+ return prio;
}
ret = fstat(fd, &st);
if (ret == -1 || !S_ISBLK(st.st_mode)) {
@@ -3568,7 +3567,6 @@ static int cdrom_probe_device(const char *filename)
outc:
qemu_close(fd);
-out:
return prio;
}
--
2.24.1
- [PATCH v1 56/59] linux-user/signal.c: remove unneeded label in do_sigaltstack(), (continued)
- [PATCH v1 56/59] linux-user/signal.c: remove unneeded label in do_sigaltstack(), Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 57/59] linux-user/syscall.c: fix trailing whitespaces and style, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 58/59] linux-user/syscall.c: remove unneeded labels, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 59/59] linux-user/vm86.c: remove unneeded label in do_vm86(), Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 05/59] ram.c: remove unneeded labels, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 14/59] block/file-posix.c: remove unneeded labels,
Daniel Henrique Barboza <=
- [PATCH v1 25/59] block/vhdx.c: remove unneeded 'exit' labels, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 29/59] cryptodev-vhost.c: remove unneeded 'err' label in cryptodev_vhost_start, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 34/59] ipmi/ipmi_bt.c: remove unneeded label in ipmi_bt_handle_event, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 35/59] ipmi_bmc_extern.c: remove unneeded label in ipmi_bmc_extern_handle_command, Daniel Henrique Barboza, 2020/01/06
- [PATCH v1 37/59] s390x/event-facility.c: remove unneeded labels, Daniel Henrique Barboza, 2020/01/06