[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing T

From: Paolo Bonzini
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry
Date: Thu, 10 Aug 2017 11:47:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

On 10/08/2017 11:35, Peter Maydell wrote:
>> actual default for un-matched: "recent contributors" + qemu-devel@
>>   $ ./scripts/get_maintainer.pl -f disas.c
>>   get_maintainer.pl: No maintainers found, printing recent contributors.
>>   get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
>>   Peter Maydell <address@hidden> (commit_signer:2/3=67%)
>>   Richard Henderson <address@hidden> (commit_signer:1/3=33%)
>>   Thomas Huth <address@hidden> (commit_signer:1/3=33%)
>>   Michael Tokarev <address@hidden> (commit_signer:1/3=33%)
>>   Julian Brown <address@hidden> (commit_signer:1/3=33%)
>>   address@hidden (open list:All patches CC here)
>> I find the un-matched "recent contributors" list often confuse, due to files
>> being moved, header updated, checkpatch indented.
> Yes, the recent-contributors list is often unhelpful, which
> is partly why the script warns about them. We might perhaps
> switch the default to --no-git-fallback".

Note that if a patch touches both maintained and unmaintained files, the
recent contributors list is omitted:

    $ scripts/get_maintainer.pl -f util/cutils.c hw/ide/core.c
    John Snow <address@hidden> (supporter:IDE)
    address@hidden (open list:All patches CC here)
    address@hidden (open list:IDE)

"--no-git-fallback" is probably the right thing to do when sending a
patch series.  The maintainer that shepherds the series will take care
of unmaintained files too.

However, when sending a single patch to an unmaintained file the
contributors list usually does get the patch to the inbox of a
maintainer.  This increases the odds of getting someone's attention.
Because inexperienced contributors usually don't send large series, my
feeling is that overall "--git-fallback"'s advantage are more than the
disadvantages, especially with the above logic that was introduced in
commit c6561586f0 ("get_maintainer.pl: restrict cases where it falls
back to --git", 2014-10-23).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]