[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing T

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 18/47] MAINTAINERS: add missing TCG entry
Date: Wed, 9 Aug 2017 18:30:25 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1

[I added mails of other person who reply to this series, this mail is not directly addressed to Alex]

On 08/09/2017 11:38 AM, Alex Bennée wrote:
Philippe Mathieu-Daudé <address@hidden> writes:
Do you think there should be another entry in "Block QAPI, monitor,
command line"?
or this file (and related include) rather deserves an own section
(possibly tagged Odd Fixes) to unburden Richard?

Well the default for un-matched files is qemu-devel right? It would be
nice for it to be properly maintained but that requires someone to
step-up to the plate.

I wonder if I'm understanding correctly what the MAINTAINERS file is for and how to use it.

From an submitter view I feel a bit confused. I thought ./get_maintainer.pl would give me the list of person to email the changes I did on some file from the repository. This script seems correctly named, I'm looking for some ./get_reviewers.pl instead, to know who I'v to keep updated, apart from the ./get_maintainer.pl.

currently we have:
"M: Mail patches to: FullName <address@hidden>"
Does this imply FullName is a maintainer?
If so is it ok I do this change:

-    M: Mail patches to: FullName <address@hidden>
+    M: Maintainer: FullName <address@hidden>
+       These maintainers must be mailed on patches.
     R: Designated reviewer: FullName <address@hidden>
        These reviewers should be CCed on patches.

actual default for un-matched: "recent contributors" + qemu-devel@

  $ ./scripts/get_maintainer.pl -f disas.c
  get_maintainer.pl: No maintainers found, printing recent contributors.
  get_maintainer.pl: Do not blindly cc: them on patches!  Use common sense.
  Peter Maydell <address@hidden> (commit_signer:2/3=67%)
  Richard Henderson <address@hidden> (commit_signer:1/3=33%)
  Thomas Huth <address@hidden> (commit_signer:1/3=33%)
  Michael Tokarev <address@hidden> (commit_signer:1/3=33%)
  Julian Brown <address@hidden> (commit_signer:1/3=33%)
  address@hidden (open list:All patches CC here)

I find the un-matched "recent contributors" list often confuse, due to files being moved, header updated, checkpatch indented. Most of the time you get the list of queue maintainers since they accept patches and sign-of the pull request.

Having to use 'git log --follow' and 'git blame' to figure out is not bad, to be aware of who modified this file before you, but there are some files I already hit 3 times in different series, and wondered about how avoid those manual steps.

Anyway I now understand these recent contributors are not maintainers but no-designated reviewers, unwilling to be maintainers (else they'd have added a section/entry by themselves).

I also understand why Fam said it sounds weird to add an new section as "Orphan".

For the linux-headers case, if people want to be notified of changes the easiest seems to modify the update-linux-headers.sh script.

I'll review the whole series thinking differently and resend when 2.11 opens.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]