[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v2 2/7] hw/mips/mips_jazz.c: Store irq array i

From: Shannon Zhao
Subject: Re: [Qemu-trivial] [PATCH v2 2/7] hw/mips/mips_jazz.c: Store irq array in MachineState to fix memory leak
Date: Thu, 04 Jun 2015 23:23:34 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 2015/6/4 23:17, Shannon Zhao wrote:

On 2015/6/4 22:57, Michael Tokarev wrote:
04.06.2015 17:51, Shannon Zhao wrote:
>Yeah, but I think something like below would work.
>     cpu_exit_irq = &qemu_allocate_irq(cpu_request_exit, NULL, 0);
>     DMA_init(0, cpu_exit_irq);

Oh, will rethink about it. But I think maybe it's unnecessary to fix it
as it actually requires a pointer which stores qemu_irq.

And if we want to use qemu_allocate_irq here, it will be something like:

cpu_exit_irq = g_new(qemu_irq, 1);
cpu_exit_irq[0] = qemu_allocate_irq(cpu_request_exit, NULL, 0);
DMA_init(0, cpu_exit_irq);

This is what exactly qemu_allocate_irqs does.

Or we modify the DMA_init to make it take qemu_irq as parameter not qemu_irq *


reply via email to

[Prev in Thread] Current Thread [Next in Thread]