[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH v2 2/7] hw/mips/mips_jazz.c: Store irq array i

From: Shannon Zhao
Subject: Re: [Qemu-trivial] [PATCH v2 2/7] hw/mips/mips_jazz.c: Store irq array in MachineState to fix memory leak
Date: Thu, 04 Jun 2015 22:51:25 +0800
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

On 2015/6/4 22:32, Michael Tokarev wrote:
04.06.2015 17:30, Shannon Zhao wrote:

>>BTW, there's also cpu_exit_irq in this function whose allocation also
>>suffers from qemu_allocate_irqs(..., 1) API abuse.
>Yeah, missed this one.
This one isn't that simple, because it passes the result to DMA_init
which expects a pointer, even if it uses only one element of the

Yeah, but I think something like below would work.

    cpu_exit_irq = &qemu_allocate_irq(cpu_request_exit, NULL, 0);
    DMA_init(0, cpu_exit_irq);


reply via email to

[Prev in Thread] Current Thread [Next in Thread]