[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/9] arm: fix memory leak

From: Markus Armbruster
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/9] arm: fix memory leak
Date: Thu, 05 Mar 2015 09:47:21 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Gonglei <address@hidden> writes:

> On 2015/3/4 21:16, Michael Tokarev wrote:
>> And a much more general solution is to actually test
>> patches before submitting them.  You obviously did not
>> test this series, having 3 errors in 9 patches, ie,
>> 1/3 of your patches does not work...
> Apologize earnestly for troubling you. :(
> I just thought they are so trivial, meanwhile I hadn't arm compiling
> environment (lack of
> libfdt-dev), and assigned "--target-list=x86_64-softmmu" that moment.

Hard-won personal experience: the more trivial a change is, the more
likely I am to screw it up in some stupid way.

In other words: no change is too trivial to screw it up.

Corollary: no change is trivial enough to skip testing.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]