[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH 2/9] arm: fix memory leak

From: Michael Tokarev
Subject: Re: [Qemu-trivial] [PATCH 2/9] arm: fix memory leak
Date: Wed, 04 Mar 2015 16:16:32 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0

27.02.2015 10:50, address@hidden wrote:
> @@ -565,6 +565,7 @@ static void create_flash(const VirtBoardInfo *vbi)
>              error_report("Could not load ROM image '%s'", bios_name);
>              exit(1);
>          }
> +        g_free(fn);
>      }
>      create_one_flash("virt.flash0", flashbase, flashsize);

This change introduces a compiler error:

hw/arm/virt.c: In function ‘create_flash’:
hw/arm/virt.c:568:16: error: passing argument 1 of ‘g_free’ discards ‘const’ 
qualifier from pointer target type [-Werror]
/usr/include/glib-2.0/glib/gmem.h:69:7: note: expected ‘gpointer’ but argument 
is of type ‘const char *’
 void  g_free           (gpointer  mem);

This is because just a few lines above, `fn' variable
is declared as `const char *', which obviously should
not be used with any *free() functions.

The solution is to remove `const' from the variable

And a much more general solution is to actually test
patches before submitting them.  You obviously did not
test this series, having 3 errors in 9 patches, ie,
1/3 of your patches does not work...



reply via email to

[Prev in Thread] Current Thread [Next in Thread]