[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly

From: Peter Maydell
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h
Date: Mon, 7 Jan 2013 17:50:14 +0000

On 7 January 2013 17:38, Stefan Weil <address@hidden> wrote:
> Am 07.01.2013 18:29, schrieb Peter Maydell:
>> Explicitly include string.h to avoid warnings under MacOS X/clang
>> about implicit declarations of strerror() and strlen().

> Better: include qemu-common.h first and remove all
> three standard includes.

This would be reversing direction from commit 4d4922c33...
I took the commit message in that commit to imply that we
shouldn't be including qemu-common.h for standalone
executables like qga.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]