[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly

From: Stefan Weil
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qga/channel-posix.c: Explicitly include string.h
Date: Mon, 07 Jan 2013 18:38:13 +0100
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20121215 Iceowl/1.0b1 Icedove/3.0.11

Am 07.01.2013 18:29, schrieb Peter Maydell:
Explicitly include string.h to avoid warnings under MacOS X/clang
about implicit declarations of strerror() and strlen().

Signed-off-by: Peter Maydell<address@hidden>
I assume under Linux these are implicitly dragged in via one of the
other headers.

  qga/channel-posix.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index d4fd628..ca9e4aa 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -4,6 +4,7 @@
  #include "qemu/osdep.h"
  #include "qemu/sockets.h"
  #include "qga/channel.h"

Better: include qemu-common.h first and remove all
three standard includes.

- Stefan

reply via email to

[Prev in Thread] Current Thread [Next in Thread]