[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-trivial] [PATCH] configure: Avoid duplicate flags when calling com
From: |
Stefan Weil |
Subject: |
[Qemu-trivial] [PATCH] configure: Avoid duplicate flags when calling compile_prog |
Date: |
Sun, 4 Sep 2011 18:30:02 +0200 |
This patch removes redundant shell code and cleans it a little bit.
Shell macro compile_prog takes two arguments:
local_cflags and local ldflags.
$QEMU_CFLAGS is added automatically to the cflags, so there is no need
to pass it as an argument.
It is also unnecessary to pass -Werror twice.
$flag is a compiler warning option, so it should be in local_cflags
instead of local_ldflags.
Signed-off-by: Stefan Weil <address@hidden>
---
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index c3044c7..d261fdd 100755
--- a/configure
+++ b/configure
@@ -1071,7 +1071,7 @@ cat > $TMPC << EOF
int main(void) { return 0; }
EOF
for flag in $gcc_flags; do
- if compile_prog "-Werror $QEMU_CFLAGS" "-Werror $flag" ; then
+ if compile_prog "$flag -Werror" "" ; then
QEMU_CFLAGS="$QEMU_CFLAGS $flag"
fi
done
--
1.7.0.4
- [Qemu-trivial] [PATCH] configure: Avoid duplicate flags when calling compile_prog,
Stefan Weil <=