[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] configure: Avoid duplicate flags when calling

From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH] configure: Avoid duplicate flags when calling compile_prog
Date: Tue, 6 Sep 2011 15:21:19 +0100
User-agent: Mutt/1.5.21 (2010-09-15)

On Sun, Sep 04, 2011 at 06:30:02PM +0200, Stefan Weil wrote:
> This patch removes redundant shell code and cleans it a little bit.
> Shell macro compile_prog takes two arguments:
> local_cflags and local ldflags.
> $QEMU_CFLAGS is added automatically to the cflags, so there is no need
> to pass it as an argument.
> It is also unnecessary to pass -Werror twice.
> $flag is a compiler warning option, so it should be in local_cflags
> instead of local_ldflags.
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  configure |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Thanks, applied to the trivial patches -next tree:


reply via email to

[Prev in Thread] Current Thread [Next in Thread]