[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] tests/tcg/s390x: Add C(G)HRL test

From: Nina Schoetterl-Glausch
Subject: Re: [PATCH v2 2/2] tests/tcg/s390x: Add C(G)HRL test
Date: Thu, 09 Mar 2023 15:55:59 +0100
User-agent: Evolution 3.46.4 (3.46.4-1.fc37)

On Thu, 2023-03-09 at 14:47 +0100, Thomas Huth wrote:
> On 08/03/2023 22.02, Nina Schoetterl-Glausch wrote:
> > Test that the bytes following the second operand do not affect the
> > instruction.
> > Test the sign extension performed on the second operand.
> > 
> > Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
> > ---
> > 
> > 
> > I don't know what the coding style is for inline asm.
> > checkpatch.sh complains about the tabs inside the asm, which I find a
> > bit surprising given they're inside a string.
> > IMO emitting tabs makes sense in order to be consistent with gcc output.
> > I left the tabs in for now, but can remove them.
> I don't mind too much, but all the other files use spaces, not tabs, so I 
> think it's maybe best to also use spaces here for consistency?

Seems pretty inconsistent. Sometimes \t is used everywhere, sometimes some 
number of spaces.
I'll put \n\t at the end of lines, put the labels on a separate line and use a 
single space
between the mnemonic and the operands.
>   Thomas

reply via email to

[Prev in Thread] Current Thread [Next in Thread]