qemu-s390x
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/2] tests/tcg/s390x: Add C(G)HRL test


From: Thomas Huth
Subject: Re: [PATCH v2 2/2] tests/tcg/s390x: Add C(G)HRL test
Date: Thu, 9 Mar 2023 14:47:53 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0

On 08/03/2023 22.02, Nina Schoetterl-Glausch wrote:
Test COMPARE HALFWORD RELATIVE LONG instructions.
Test that the bytes following the second operand do not affect the
instruction.
Test the sign extension performed on the second operand.

Signed-off-by: Nina Schoetterl-Glausch <nsg@linux.ibm.com>
---


I don't know what the coding style is for inline asm.
checkpatch.sh complains about the tabs inside the asm, which I find a
bit surprising given they're inside a string.
IMO emitting tabs makes sense in order to be consistent with gcc output.
I left the tabs in for now, but can remove them.

I don't mind too much, but all the other files use spaces, not tabs, so I think it's maybe best to also use spaces here for consistency?

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]