[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd mo
From: |
Richard Henderson |
Subject: |
Re: [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd more places |
Date: |
Fri, 22 Feb 2019 13:43:25 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/22/19 12:45 PM, Alex Bennée wrote:
> @@ -3526,6 +3551,8 @@ static float32 roundAndPackFloat32(flag zSign, int
> zExp, uint32_t zSig,
> case float_round_down:
> roundIncrement = zSign ? 0x7f : 0;
> break;
> + case float_round_to_odd:
> + roundIncrement = zSig & 0x80 ? 0 : 0x7f;
> default:
> abort();
I clearly missed a break here.
Since this didn't kill fp-test, are we missing a float128_to_float32 test?
r~
- [qemu-s390x] [PATCH v1 0/6] fpu/next, mostly bits s390x tcg will need, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 5/6] tests/fp: enable f128_to_ui[32/64] tests in float-to-uint, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 3/6] softfloat: Implement float128_to_uint32, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd more places, Alex Bennée, 2019/02/22
- Re: [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd more places,
Richard Henderson <=
- [qemu-s390x] [PATCH v1 4/6] tests/fp: add wrapping for f128_to_ui32, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 2/6] softfloat: add float128_is_{normal, denormal}, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 1/6] tests: Ignore fp test outputs, Alex Bennée, 2019/02/22