[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd mo
|
From: |
Alex Bennée |
|
Subject: |
Re: [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd more places |
|
Date: |
Sat, 23 Feb 2019 10:19:06 +0000 |
|
User-agent: |
mu4e 1.1.0; emacs 26.1 |
Richard Henderson <address@hidden> writes:
> On 2/22/19 12:45 PM, Alex Bennée wrote:
>> @@ -3526,6 +3551,8 @@ static float32 roundAndPackFloat32(flag zSign, int
>> zExp, uint32_t zSig,
>> case float_round_down:
>> roundIncrement = zSign ? 0x7f : 0;
>> break;
>> + case float_round_to_odd:
>> + roundIncrement = zSig & 0x80 ? 0 : 0x7f;
>> default:
>> abort();
>
> I clearly missed a break here.
>
> Since this didn't kill fp-test, are we missing a float128_to_float32
> test?
So I've not got -r all against all tests but adding it to make mulAdd
take even longer to run so maybe I'll not bother for mulAdd.
>
>
> r~
--
Alex Bennée
- [qemu-s390x] [PATCH v1 0/6] fpu/next, mostly bits s390x tcg will need, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 5/6] tests/fp: enable f128_to_ui[32/64] tests in float-to-uint, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 3/6] softfloat: Implement float128_to_uint32, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 6/6] softfloat: Support float_round_to_odd more places, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 4/6] tests/fp: add wrapping for f128_to_ui32, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 2/6] softfloat: add float128_is_{normal, denormal}, Alex Bennée, 2019/02/22
- [qemu-s390x] [PATCH v1 1/6] tests: Ignore fp test outputs, Alex Bennée, 2019/02/22