[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [qemu-s390x] [PATCH 06/18] Acceptance tests: use "arch:" tag to filt

From: Caio Carrara
Subject: Re: [qemu-s390x] [PATCH 06/18] Acceptance tests: use "arch:" tag to filter target specific tests
Date: Mon, 21 Jan 2019 18:24:09 -0200
User-agent: Mutt/1.10.1 (2018-07-13)

On Thu, Jan 17, 2019 at 01:56:16PM -0500, Cleber Rosa wrote:
> Currently, the only test that contains some target architecture
> information is "boot_linux_console.py" which test contains a "x86_64"
> tag.  But that tag is not respected in the default execution, that is,
> "make check-acceptance" doesn't do anything with it.
> That said, even the target architecture handling currently present in
> the "avocado_qemu.Test" class, class is pretty limited.  For instance,
> by default, it chooses a target based on the host architecture.
> Because the original implementation of the tags feature in Avocado did
> not include any time of namespace or "key:val" mechanism, no tag has
> relation to another tag.  The new implementation of the tags feature
> from version 67.0 onwards, allows "key:val" tags, and because of that,
> a test can be classified with a tag in a given key.  For instance, the
> new proposed version of the "boot_linux_console.py" test, which
> downloads and attempts to run a x86_64 kernel, is now tagged as:
>   :avocado: tags=arch:x86_64
> This means that it can be filtered (out) when no x86_64 target is
> available.  At the same time, tests that don't have a "arch:" tag,
> will not be filtered out.
> Signed-off-by: Cleber Rosa <address@hidden>

Reviewed-by: Caio Carrara <address@hidden>

> ---
>  tests/Makefile.include                 | 3 +++
>  tests/acceptance/boot_linux_console.py | 2 +-
>  tests/requirements.txt                 | 2 +-
>  3 files changed, 5 insertions(+), 2 deletions(-)

Caio Carrara
Software Engineer, Virt Team - Red Hat

reply via email to

[Prev in Thread] Current Thread [Next in Thread]