Re: [qemu-s390x] [PATCH 00/18] Acceptance Tests: target architecture support

[Aleksandar Markovic]

> From: Cleber Rosa <address@hidden>

>   class My(Test):
>       def test_nx_cpu_flag(self):
>           """
>           :avocado: tags=arch:x86_64
>           """
>           test_code()

> The value of the "arch" key, in this case, "x86_64" will be used when
> selecting the QEMU binary to use in the test.  At the same time, if
> "x86_64-softmmu" is not a built target, the test will be filtered out
> by "make check-acceptance"[3].

I think, the term "arch" is a little problematic in QEMU parlance. IMHO,
"target" should be used instead. ("arch" is used in Linux kernel community)

The overall structure of the "tags" should be a little different. My
suggestion:

"target"
"isa" (instruction set architecture, determeines how the kernel and rootfs are 
built)
"cpu"
"machine"

This would allow clear view what a particular acceptance test tests, and will
enforce consistency and clarity in the test organization across the board.

That said, I am very excited about this series.

Regards,
Aleksandar