Re: [PATCH 05/10] meson: Add wasm build in build scripts

[Paolo Bonzini]

On 4/9/25 12:55, Philippe Mathieu-Daudé wrote:
> Cc'ing Pierrick
>
> On 7/4/25 16:45, Kohei Tokunaga wrote:
> > has_int128_type is set to false on emscripten as of now to avoid errors by
> > libffi.

What is the error here?  How hard would it be to test for it?

> > And tests aren't integrated with Wasm execution environment as of
> > now so this commit disables tests.

Perhaps it would be enough to add

[binaries]
exe_wrapper = 'node'

to the emscripten.txt file?

> > +[built-in options]
> > +c_args = ['-Wno-unused-command-line-argument','-g','-O3','-pthread']
> > +cpp_args = ['-Wno-unused-command-line-argument','-g','-O3','-pthread']
> > +objc_args = ['-Wno-unused-command-line-argument','-g','-O3','-pthread']
> > +c_link_args = ['-Wno-unused-command-line-argument','-g','-O3','- 
> > pthread','-sASYNCIFY=1','-sPROXY_TO_PTHREAD=1','-sFORCE_FILESYSTEM','- 
> > sALLOW_TABLE_GROWTH','-sTOTAL_MEMORY=2GB','-sWASM_BIGINT','- 
> > sEXPORT_ES6=1','-sASYNCIFY_IMPORTS=ffi_call_js','- 
> > sEXPORTED_RUNTIME_METHODS=addFunction,removeFunction,TTY,FS']
> > +cpp_link_args = ['-Wno-unused-command-line-argument','-g','-O3','- 
> > pthread','-sASYNCIFY=1','-sPROXY_TO_PTHREAD=1','-sFORCE_FILESYSTEM','- 
> > sALLOW_TABLE_GROWTH','-sTOTAL_MEMORY=2GB','-sWASM_BIGINT','- 
> > sEXPORT_ES6=1','-sASYNCIFY_IMPORTS=ffi_call_js','- 
> > sEXPORTED_RUNTIME_METHODS=addFunction,removeFunction,TTY,FS']

At least -g -O3 -pthread should not be necessary.

For -Wno-unused-command-line-argument what are the warnings/errors that 
you are getting?

> > +elif host_os == 'emscripten'
> > +  supported_backends += ['fiber']

Can you rename the backend to 'wasm' since the 'windows' backend also 
uses an API called Fibers?

Otherwise the changes look good.

Paolo