|
From: | Richard Henderson |
Subject: | Re: [PATCH 4/8] target/riscv: Remove check on RVH for riscv_cpu_set_virt_enabled |
Date: | Fri, 24 Mar 2023 11:10:13 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 |
On 3/24/23 05:38, Weiwei Li wrote:
In current implementation, riscv_cpu_set_virt_enabled is only called when RVH is enabled. Signed-off-by: Weiwei Li<liweiwei@iscas.ac.cn> Signed-off-by: Junqiang Wang<wangjunqiang@iscas.ac.cn> --- target/riscv/cpu_helper.c | 4 ---- 1 file changed, 4 deletions(-)
Perhaps assert, or assert under CONFIG_DEBUG. Otherwise the function deserves a comment about the interface. With that, Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
[Prev in Thread] | Current Thread | [Next in Thread] |