[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 12/15] target/riscv: rvb: generalized or-combine
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC 12/15] target/riscv: rvb: generalized or-combine |
|
Date: |
Thu, 19 Nov 2020 13:28:21 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 11/18/20 12:29 AM, frank.chang@sifive.com wrote:
> +static target_ulong do_gorc(target_ulong rs1,
> + target_ulong rs2,
> + const target_ulong masks[])
Similar comments to grev. I'll also say that the masks array should *not* be
local to do_grev, but placed at file level so that it can be shared between the
two functions.
r~
- Re: [RFC 08/15] target/riscv: rvb: single-bit instructions, (continued)
- [RFC 09/15] target/riscv: rvb: shift ones, frank . chang, 2020/11/18
- [RFC 10/15] target/riscv: rvb: rotate (left/right), frank . chang, 2020/11/18
- [RFC 11/15] target/riscv: rvb: generalized reverse, frank . chang, 2020/11/18
- [RFC 12/15] target/riscv: rvb: generalized or-combine, frank . chang, 2020/11/18
- Re: [RFC 12/15] target/riscv: rvb: generalized or-combine,
Richard Henderson <=
- [RFC 13/15] target/riscv: rvb: address calculation, frank . chang, 2020/11/18
- [RFC 14/15] target/riscv: rvb: add/sub with postfix zero-extend, frank . chang, 2020/11/18
- [RFC 15/15] target/riscv: rvb: support and turn on B-extension from command line, frank . chang, 2020/11/18
- Re: [RFC 00/15] support subsets of bitmanip extension, Richard Henderson, 2020/11/19