Re: [PATCH v4 4/5] target/riscv: Remove the hyp load and store functions

qemu-riscv

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 4/5] target/riscv: Remove the hyp load and store functions

From:	Richard Henderson
Subject:	Re: [PATCH v4 4/5] target/riscv: Remove the hyp load and store functions
Date:	Wed, 4 Nov 2020 08:30:04 -0800
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0

On 11/3/20 8:43 PM, Alistair Francis wrote:
> +#ifndef CONFIG_USER_ONLY
> +static void check_access(DisasContext *ctx) {

Newline before {.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v4 0/5] Fix the Hypervisor access functions, Alistair Francis, 2020/11/03
- [PATCH v4 1/5] target/riscv: Add a virtualised MMU Mode, Alistair Francis, 2020/11/03
  - Re: [PATCH v4 1/5] target/riscv: Add a virtualised MMU Mode, Richard Henderson, 2020/11/04
- [PATCH v4 3/5] target/riscv: Remove the HS_TWO_STAGE flag, Alistair Francis, 2020/11/03
- [PATCH v4 2/5] target/riscv: Set the virtualised MMU mode when doing hyp accesses, Alistair Francis, 2020/11/03
- [PATCH v4 5/5] target/riscv: Split the Hypervisor execute load helpers, Alistair Francis, 2020/11/03
- [PATCH v4 4/5] target/riscv: Remove the hyp load and store functions, Alistair Francis, 2020/11/03
  - Re: [PATCH v4 4/5] target/riscv: Remove the hyp load and store functions, Richard Henderson <=

Prev by Date: Re: [PATCH v4 1/5] target/riscv: Add a virtualised MMU Mode
Next by Date: [RFC PATCH 02/15] hw/riscv: migrate fdt field to generic MachineState
Previous by thread: [PATCH v4 4/5] target/riscv: Remove the hyp load and store functions
Next by thread: [RFC PATCH 02/15] hw/riscv: migrate fdt field to generic MachineState
Index(es):
- Date
- Thread