[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 1/5] target/riscv: Add a virtualised MMU Mode
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v4 1/5] target/riscv: Add a virtualised MMU Mode |
|
Date: |
Wed, 4 Nov 2020 08:24:24 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 11/3/20 8:43 PM, Alistair Francis wrote:
> -#define NB_MMU_MODES 4
> +/*
> + * The current MMU Modes are:
> + * - U mode 0b000
> + * - S mode 0b001
> + * - M mode 0b011
> + * - U mode HLV/HLVX/HSV 0b100
> + * - S mode HLV/HLVX/HSV 0b101
> + * - M mode HLV/HLVX/HSV 0b111
> + */
> +#define NB_MMU_MODES 6
6 modes, but you're leaving two holes, so you need 8 here.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- [PATCH v4 0/5] Fix the Hypervisor access functions, Alistair Francis, 2020/11/03
- [PATCH v4 1/5] target/riscv: Add a virtualised MMU Mode, Alistair Francis, 2020/11/03
- Re: [PATCH v4 1/5] target/riscv: Add a virtualised MMU Mode,
Richard Henderson <=
- [PATCH v4 3/5] target/riscv: Remove the HS_TWO_STAGE flag, Alistair Francis, 2020/11/03
- [PATCH v4 2/5] target/riscv: Set the virtualised MMU mode when doing hyp accesses, Alistair Francis, 2020/11/03
- [PATCH v4 5/5] target/riscv: Split the Hypervisor execute load helpers, Alistair Francis, 2020/11/03
- [PATCH v4 4/5] target/riscv: Remove the hyp load and store functions, Alistair Francis, 2020/11/03