[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 19/23] ppc/vof: Fix uninitialized string tracing
From: |
Daniel Henrique Barboza |
Subject: |
[PULL 19/23] ppc/vof: Fix uninitialized string tracing |
Date: |
Wed, 20 Apr 2022 19:13:25 -0300 |
From: Alexey Kardashevskiy <aik@ozlabs.ru>
There are error paths which do not initialize propname but the trace_exit
label prints it anyway. This initializes the problem string.
Spotted by Coverity CID 1487241.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20220406045013.3610172-1-aik@ozlabs.ru>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/ppc/vof.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c
index 8d96593677..18c3f92317 100644
--- a/hw/ppc/vof.c
+++ b/hw/ppc/vof.c
@@ -293,7 +293,7 @@ static uint32_t vof_setprop(MachineState *ms, void *fdt,
Vof *vof,
uint32_t nodeph, uint32_t pname,
uint32_t valaddr, uint32_t vallen)
{
- char propname[OF_PROPNAME_LEN_MAX + 1];
+ char propname[OF_PROPNAME_LEN_MAX + 1] = "";
uint32_t ret = PROM_ERROR;
int offset, rc;
char trval[64] = "";
--
2.35.1
- [PULL 09/23] spapr: Move nested KVM hypercalls under a TCG only config., (continued)
- [PULL 09/23] spapr: Move nested KVM hypercalls under a TCG only config., Daniel Henrique Barboza, 2022/04/20
- [PULL 10/23] target/ppc: Improve KVM hypercall trace, Daniel Henrique Barboza, 2022/04/20
- [PULL 11/23] qemu/int128: add int128_urshift, Daniel Henrique Barboza, 2022/04/20
- [PULL 12/23] softfloat: add uint128_to_float128, Daniel Henrique Barboza, 2022/04/20
- [PULL 13/23] softfloat: add int128_to_float128, Daniel Henrique Barboza, 2022/04/20
- [PULL 14/23] softfloat: add float128_to_uint128, Daniel Henrique Barboza, 2022/04/20
- [PULL 15/23] softfloat: add float128_to_int128, Daniel Henrique Barboza, 2022/04/20
- [PULL 16/23] target/ppc: implement xscv[su]qqp, Daniel Henrique Barboza, 2022/04/20
- [PULL 17/23] target/ppc: implement xscvqp[su]qz, Daniel Henrique Barboza, 2022/04/20
- [PULL 18/23] hw/ppc/ppc405_boards: Initialize g_autofree pointer, Daniel Henrique Barboza, 2022/04/20
- [PULL 19/23] ppc/vof: Fix uninitialized string tracing,
Daniel Henrique Barboza <=
- [PULL 20/23] pcie: Don't try triggering a LSI when not defined, Daniel Henrique Barboza, 2022/04/20
- [PULL 21/23] ppc/pnv: Remove LSI on the PCIE host bridge, Daniel Henrique Barboza, 2022/04/20
- [PULL 22/23] target/ppc: Add two missing register callbacks on POWER10, Daniel Henrique Barboza, 2022/04/20
- [PULL 23/23] hw/ppc: change indentation to spaces from TABs, Daniel Henrique Barboza, 2022/04/20
- Re: [PULL 00/23] ppc queue, Richard Henderson, 2022/04/21