Re: [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions

[Bruno Piazera Larsen]

On 28/06/2021 11:45, Richard Henderson wrote:

> On
>       6/28/21 7:33 AM, Peter Maydell wrote:
>       
> > > +    if (have_isa_3_10) {
> > >           
> > >         
> >         
> >         Side note, why do we call this have_isa_3_10 when it's checking
> >         
> >         for ISA 3.1, not 3.10 ?
> >         
> >       
>       
>       I think it's just because it made the columns line up:
>       
>       
>       #define have_isa_2_06  (have_isa >= tcg_isa_2_06)
>       
>       #define have_isa_2_07  (have_isa >= tcg_isa_2_07)
>       
>       #define have_isa_3_00  (have_isa >= tcg_isa_3_00)
>       
>       #define have_isa_3_10  (have_isa >= tcg_isa_3_10)
>       
>       
>       though I think there's also a missing . or _ there -- should have
>       been 2.0.6 and 2.0.7.
>       
>

No. The specifications in the Open Power foundation's websites call the versions

2.07: https://openpowerfoundation.org/?resource_lib=ibm-power-isa-version-2-07-b

and 2.06: http://kib.kiev.ua/x86docs/POWER/PowerISA_V2.06B_V2_PUBLIC.pdf

Unless the PDFs also lost a . somewhere, which isn't impossible, but I find more unlikely.

>       
>       
>       r~
>       
>       
>

--
Bruno Piazera Larsen
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer