Re: [PATCH v3 12/29] tcg/ppc: Use power10 byte-reverse instructions

[Peter Maydell]

On Sat, 26 Jun 2021 at 07:41, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Cc: qemu-ppc@nongnu.org
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  tcg/ppc/tcg-target.c.inc | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

> +    if (have_isa_3_10) {

Side note, why do we call this have_isa_3_10 when it's checking
for ISA 3.1, not 3.10 ? The kernel calls its feature bit
#define PPC_FEATURE2_ARCH_3_1          0x00040000 /* ISA 3.1 */

but we seem to have gone for
#define PPC_FEATURE2_ARCH_3_10          0x00040000
in our elf.h.

thanks
-- PMM