[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v3 03/25] chardev/wctablet: Use unsigned type to hold
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
[Qemu-ppc] [PATCH v3 03/25] chardev/wctablet: Use unsigned type to hold unsigned value |
|
Date: |
Wed, 20 Feb 2019 02:02:10 +0100 |
TabletChardev::query is an array of uint8_t.
Use the same type to hold it (this also silent a -Wsign-conversion
warning in the trace function).
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
chardev/trace-events | 2 +-
chardev/wctablet.c | 5 +++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/chardev/trace-events b/chardev/trace-events
index d0e5f3bbc1..562bfe70e9 100644
--- a/chardev/trace-events
+++ b/chardev/trace-events
@@ -5,7 +5,7 @@ wct_init(void) ""
wct_cmd_re(void) ""
wct_cmd_st(void) ""
wct_cmd_sp(void) ""
-wct_cmd_ts(int input) "0x%02x"
+wct_cmd_ts(uint8_t input) "0x%02x"
wct_cmd_other(const char *cmd) "%s"
wct_speed(int speed) "%d"
diff --git a/chardev/wctablet.c b/chardev/wctablet.c
index 35dbd29a33..cf7a08a363 100644
--- a/chardev/wctablet.c
+++ b/chardev/wctablet.c
@@ -207,7 +207,8 @@ static int wctablet_chr_write(struct Chardev *chr,
const uint8_t *buf, int len)
{
TabletChardev *tablet = WCTABLET_CHARDEV(chr);
- unsigned int i, clen;
+ size_t i;
+ unsigned int clen;
char *pos;
if (tablet->line_speed != 9600) {
@@ -269,7 +270,7 @@ static int wctablet_chr_write(struct Chardev *chr,
} else if (strncmp((char *)tablet->query, "TS", 2) == 0 &&
clen == 3) {
- unsigned int input = tablet->query[2];
+ uint8_t input = tablet->query[2];
uint8_t codes[7] = {
0xa3,
((input & 0x80) == 0) ? 0x7e : 0x7f,
--
2.20.1
- Re: [Qemu-ppc] [PATCH v3 06/25] gdbstub: Use size_t to hold GDBState::last_packet_len, (continued)
- [Qemu-ppc] [RFC PATCH v3 13/25] xen: Let buffer_append() return a size_t, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 08/25] ui/gtk: Remove pointless cast, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 11/25] xen: Let xencons_send() take a 'size' argument, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 05/25] gdbstub: Use size_t for strlen() return value, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 03/25] chardev/wctablet: Use unsigned type to hold unsigned value,
Philippe Mathieu-Daudé <=
- [Qemu-ppc] [PATCH v3 02/25] chardev: Assert IOCanReadHandler can not be negative, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 01/25] chardev: Simplify IOWatchPoll::fd_can_read as a GSourceFunc, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 04/25] chardev: Let qemu_chr_be_can_write() return a size_t types, Philippe Mathieu-Daudé, 2019/02/19