[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [RFC PATCH v3 13/25] xen: Let buffer_append() return a size_t
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-ppc] [RFC PATCH v3 13/25] xen: Let buffer_append() return a size_t |
Date: |
Wed, 20 Feb 2019 02:02:20 +0100 |
To the Xen team: this is not trivial to me to demonstrate
this assertion can never happen, but then the whole series
is justified and I can convert qemu_chr_fe_write() to use
size_t argument.
Can you help me here?
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/char/xen_console.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c
index 1a30014a11..5b672a5a24 100644
--- a/hw/char/xen_console.c
+++ b/hw/char/xen_console.c
@@ -92,6 +92,7 @@ static ssize_t buffer_append(struct XenConsole *con)
}
out:
+ assert(buffer->size >= buffer->consumed);
return buffer->size - buffer->consumed;
}
--
2.20.1
- [Qemu-ppc] [PATCH v3 14/25] virtio-serial: Let VirtIOSerialPortClass::have_data() use size_t, (continued)
- [Qemu-ppc] [PATCH v3 14/25] virtio-serial: Let VirtIOSerialPortClass::have_data() use size_t, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 12/25] xen: Let buffer_append() return the size consumed, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 09/25] vhost-user: Express sizeof with size_t, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 07/25] gdbstub: Let put_buffer() use size_t, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 06/25] gdbstub: Use size_t to hold GDBState::last_packet_len, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [RFC PATCH v3 13/25] xen: Let buffer_append() return a size_t,
Philippe Mathieu-Daudé <=
- [Qemu-ppc] [PATCH v3 08/25] ui/gtk: Remove pointless cast, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 11/25] xen: Let xencons_send() take a 'size' argument, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 05/25] gdbstub: Use size_t for strlen() return value, Philippe Mathieu-Daudé, 2019/02/19
- [Qemu-ppc] [PATCH v3 03/25] chardev/wctablet: Use unsigned type to hold unsigned value, Philippe Mathieu-Daudé, 2019/02/19