[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 06/10] hw/i386/multiboot.c: Don't use load_image()
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-ppc] [PATCH 06/10] hw/i386/multiboot.c: Don't use load_image() |
|
Date: |
Fri, 30 Nov 2018 14:28:35 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 |
On 11/30/18 9:17 AM, Peter Maydell wrote:
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Instead use load_image_size().
Commit message should mention the added error checking.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/i386/multiboot.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [Qemu-ppc] [PATCH 00/10] Remove deprecated load_image() function, Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 10/10] include/hw/loader.h: Document load_image_size(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 08/10] device_tree.c: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 06/10] hw/i386/multiboot.c: Don't use load_image(), Peter Maydell, 2018/11/30
- Re: [Qemu-ppc] [PATCH 06/10] hw/i386/multiboot.c: Don't use load_image(),
Eric Blake <=
- [Qemu-ppc] [PATCH 02/10] hw/ppc/ppc405_boards: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 04/10] hw/pci/pci.c: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 03/10] hw/smbios/smbios.c: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 01/10] hw/ppc/mac_newworld, mac_oldworld: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 07/10] hw/block/tc58128.c: Don't use load_image(), Peter Maydell, 2018/11/30