[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 06/10] hw/i386/multiboot.c: Don't use load_image()
From: |
Peter Maydell |
Subject: |
[Qemu-ppc] [PATCH 06/10] hw/i386/multiboot.c: Don't use load_image() |
Date: |
Fri, 30 Nov 2018 15:17:08 +0000 |
The load_image() function is deprecated, as it does not let the
caller specify how large the buffer to read the file into is.
Instead use load_image_size().
Signed-off-by: Peter Maydell <address@hidden>
---
hw/i386/multiboot.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c
index 1a4344f5fc3..62340687e8e 100644
--- a/hw/i386/multiboot.c
+++ b/hw/i386/multiboot.c
@@ -343,7 +343,11 @@ int load_multiboot(FWCfgState *fw_cfg,
mbs.mb_buf_size = TARGET_PAGE_ALIGN(mb_mod_length +
mbs.mb_buf_size);
mbs.mb_buf = g_realloc(mbs.mb_buf, mbs.mb_buf_size);
- load_image(one_file, (unsigned char *)mbs.mb_buf + offs);
+ if (load_image_size(one_file, (unsigned char *)mbs.mb_buf + offs,
+ mbs.mb_buf_size - offs) < 0) {
+ error_report("Error loading file '%s'", one_file);
+ exit(1);
+ }
mb_add_mod(&mbs, mbs.mb_buf_phys + offs,
mbs.mb_buf_phys + offs + mb_mod_length, c);
--
2.19.1
- [Qemu-ppc] [PATCH 00/10] Remove deprecated load_image() function, Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 10/10] include/hw/loader.h: Document load_image_size(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 08/10] device_tree.c: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 06/10] hw/i386/multiboot.c: Don't use load_image(),
Peter Maydell <=
- [Qemu-ppc] [PATCH 02/10] hw/ppc/ppc405_boards: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 04/10] hw/pci/pci.c: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 03/10] hw/smbios/smbios.c: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 01/10] hw/ppc/mac_newworld, mac_oldworld: Don't use load_image(), Peter Maydell, 2018/11/30
- [Qemu-ppc] [PATCH 07/10] hw/block/tc58128.c: Don't use load_image(), Peter Maydell, 2018/11/30