[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 1/4] add QemuSupportState

From: Eduardo Habkost
Subject: Re: [Qemu-ppc] [PATCH 1/4] add QemuSupportState
Date: Tue, 30 Oct 2018 12:02:00 -0300
User-agent: Mutt/1.9.2 (2017-12-15)

On Tue, Oct 30, 2018 at 12:13:45PM +0100, Gerd Hoffmann wrote:
> Indicates support state for somerhing (device, backend, subsystem, ...)
> in qemu.  Modeled roughly after the "S:" states we have in MAINTANERS.
> Signed-off-by: Gerd Hoffmann <address@hidden>
> +typedef struct QemuSupportState {
> +    SupportState state;
> +    const char *reason;
> +} QemuSupportState;

I find it weird that we're calling this field "reason", while
this is how the field is being actually used:

* "use a newer machine type instead"
* "use 40p machine type instead"
* "use '-vga std' instead"

These are not reasons for deprecation, they are just suggested


reply via email to

[Prev in Thread] Current Thread [Next in Thread]