[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/4] add QemuSupportState

From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/4] add QemuSupportState
Date: Tue, 30 Oct 2018 15:13:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1

On 30/10/18 15:00, Gerd Hoffmann wrote:
On Tue, Oct 30, 2018 at 02:32:40PM +0100, Philippe Mathieu-Daudé wrote:
Hi Gerd,

On 30/10/18 12:13, Gerd Hoffmann wrote:
Indicates support state for somerhing (device, backend, subsystem, ...)


Oops, I'll fix.

+# @SupportState:
+# Indicate Support level of qemu devices, backends, subsystems, ...
+# Since: 3.2
+{ 'enum': 'SupportState',
+  'data': [ 'unknown',

'unknown' is scary and should be fixed.

'unknown' maps to "0" due to being first in list, so this is what you
get when it isn't explicitly set to something else.  Which make sense

Yes, I understand in your next patch, this case won't display warning to the user.

I wanted to say "we should fix those entries in the MAINTAINERS file".

+            'supported',
+            'maintained',
+            'odd-fixes',

All those fit in 'supported'

+            'orphan',
+            'obsolete',
+            'deprecated' ] }

And all those should appear as 'deprecated' IMHO.

See minutes on deprecation discussion.  Seems there is agreement we
need something more finegrained than "supported" and "deprecated".

I read again the "Minutes of KVM Forum BoF on deprecating stuff" thread and don't find details on finegrains, can you point it to me?

I think these are fine in the MAINTAINERS entries, but don't give useful information to a QEMU user that is not custom to MAINTAINERS.

As a user I'd expect anything not "supported" to be eventually "deprecated".

Should we continue this discussion on the "Minutes of KVM Forum BoF on deprecating stuff" thread?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]