[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 13/13] spapr: Remove spapr_create_fdt_skel()
From: |
Thomas Huth |
Subject: |
Re: [Qemu-ppc] [PATCH 13/13] spapr: Remove spapr_create_fdt_skel() |
Date: |
Thu, 20 Oct 2016 10:54:54 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 20.10.2016 07:12, David Gibson wrote:
> For historical reasons construction of the guest device tree in spapr is
> divided between spapr_create_fdt_skel() which is called at init time, and
> spapr_build_fdt() which runs at reset time. Over time, more and more
> things have needed to be moved to reset time.
>
> Previous cleanups mean the only things left in spapr_create_fdt_skel() are
> the properties of the root node itself. Finish consolidating these two
> parts of device tree construction, by moving this to the start of
> spapr_build_fdt(), and removing spapr_create_fdt_skel() entirely.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/ppc/spapr.c | 94
> +++++++++++++++++++-------------------------------
> include/hw/ppc/spapr.h | 1 -
> 2 files changed, 36 insertions(+), 59 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-ppc] [PATCH 02/13] pseries: Split device tree construction from device tree load, (continued)
- [Qemu-ppc] [PATCH 02/13] pseries: Split device tree construction from device tree load, David Gibson, 2016/10/20
- [Qemu-ppc] [PATCH 06/13] pseries: Consolidate RTAS loading, David Gibson, 2016/10/20
- [Qemu-ppc] [PATCH 04/13] pseries: Make spapr_create_fdt_skel() get information from machine state, David Gibson, 2016/10/20
- [Qemu-ppc] [PATCH 05/13] pseries: Move adding of fdt reserve map entries, David Gibson, 2016/10/20
- [Qemu-ppc] [PATCH 10/13] spapr: Move /event-sources construction to spapr_build_fdt(), David Gibson, 2016/10/20
- [Qemu-ppc] [PATCH 13/13] spapr: Remove spapr_create_fdt_skel(), David Gibson, 2016/10/20
- Re: [Qemu-ppc] [PATCH 13/13] spapr: Remove spapr_create_fdt_skel(),
Thomas Huth <=
- [Qemu-ppc] [PATCH 11/13] spapr: Move /hypervisor node construction to fdt_build_fdt(), David Gibson, 2016/10/20
- [Qemu-ppc] [PATCH 07/13] spapr: Move construction of /interrupt-controller fdt node, David Gibson, 2016/10/20
- [Qemu-ppc] [PATCH 12/13] spapr: Consolidate construction of /vdevice device tree node, David Gibson, 2016/10/20
- [Qemu-ppc] [PATCH 08/13] spapr: Consolidate construction of /chosen device tree node, David Gibson, 2016/10/20