[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v5 01/10] vl: Don't allow CPU toplogies with partially
From: |
Bharata B Rao |
Subject: |
[Qemu-ppc] [PATCH v5 01/10] vl: Don't allow CPU toplogies with partially filled cores |
Date: |
Fri, 20 Nov 2015 18:24:30 +0530 |
Prevent guests from booting with CPU topologies that have partially
filled CPU cores or can result in partially filled CPU cores after
CPU hotplug like
-smp 15,sockets=1,cores=4,threads=4,maxcpus=16 or
-smp 15,sockets=1,cores=4,threads=4,maxcpus=17.
Signed-off-by: Bharata B Rao <address@hidden>
---
vl.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/vl.c b/vl.c
index 7d993a5..23a1a1e 100644
--- a/vl.c
+++ b/vl.c
@@ -1248,6 +1248,15 @@ static void smp_parse(QemuOpts *opts)
exit(1);
}
+ if (cpus % threads || max_cpus % threads) {
+ error_report("cpu topology: "
+ "sockets (%u) cores (%u) threads (%u) with "
+ "smp_cpus (%u) maxcpus (%u) "
+ "will result in partially filled cores",
+ sockets, cores, threads, cpus, max_cpus);
+ exit(1);
+ }
+
smp_cpus = cpus;
smp_cores = cores > 0 ? cores : 1;
smp_threads = threads > 0 ? threads : 1;
--
2.1.0
- Re: [Qemu-ppc] [PATCH v5 02/10] exec: Remove cpu from cpus list during cpu_exec_exit(), (continued)
- [Qemu-ppc] [PATCH v5 07/10] spapr: Enable CPU hotplug for pseries-2.5 and add CPU DRC DT entries, Bharata B Rao, 2015/11/20
- [Qemu-ppc] [PATCH v5 08/10] spapr: CPU hotplug support, Bharata B Rao, 2015/11/20
- [Qemu-ppc] [PATCH v5 03/10] exec: Do vmstate unregistration from cpu_exec_exit(), Bharata B Rao, 2015/11/20
- [Qemu-ppc] [PATCH v5 09/10] spapr: CPU hot unplug support, Bharata B Rao, 2015/11/20
- [Qemu-ppc] [PATCH v5 10/10] target-ppc: Enable CPU hotplug for POWER8 CPU family, Bharata B Rao, 2015/11/20
- [Qemu-ppc] [PATCH v5 01/10] vl: Don't allow CPU toplogies with partially filled cores,
Bharata B Rao <=
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v5 00/10] sPAPR CPU hotplug, Peter Krempa, 2015/11/23