[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to mach
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/6] target-ppc: Convert PReP to machine class |
Date: |
Tue, 31 Mar 2015 16:40:44 +1100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Mar 30, 2015 at 11:33:43PM +0200, Andreas Färber wrote:
> Am 06.03.2015 um 05:18 schrieb David Gibson:
> > The more commonly used ppc machine types: spapr, and newworld Mac have
> > already been converted to the newer MachineClass representation, but some
> > others still use QEMUMachine.
> >
> > This patch cleans things up slightly, by converting the "prep" machine
> > type to the new style.
> >
> > Signed-off-by: David Gibson <address@hidden>
> > ---
> > hw/ppc/prep.c | 30 +++++++++++++++++++++---------
> > 1 file changed, 21 insertions(+), 9 deletions(-)
> >
> > diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c
> > index 15df7f3..dfc8689 100644
> > --- a/hw/ppc/prep.c
> > +++ b/hw/ppc/prep.c
> > @@ -44,6 +44,8 @@
> > #include "exec/address-spaces.h"
> > #include "elf.h"
> >
> > +#define TYPE_PREP_MACHINE "PReP-machine"
> [snip]
>
> qemu_register_machine() generated the type name by concatenating
> QEMUMachine::name with "-machine", so this should be "prep-machine".
Ah, I thought the type names were internal only and therefore
changeable. I've corrected this.
> Otherwise looks great.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgppkYCfcKbZy.pgp
Description: PGP signature
- [Qemu-ppc] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259, (continued)
- [Qemu-ppc] [PATCH 1/6] Split serial-isa into its own config option, David Gibson, 2015/03/05
- [Qemu-ppc] [PATCH 4/6] target-ppc: Convert PReP to machine class, David Gibson, 2015/03/05
- [Qemu-ppc] [PATCH 3/6] pc: Use MachineClass callbacks for "irq" and "pic" hmp commands, David Gibson, 2015/03/05
- Re: [Qemu-ppc] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build, Alexander Graf, 2015/03/06
- Re: [Qemu-ppc] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build, Michael S. Tsirkin, 2015/03/10