[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on C
From: |
Andreas Färber |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259 |
Date: |
Mon, 30 Mar 2015 23:41:17 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 |
Am 06.03.2015 um 05:18 schrieb David Gibson:
> The hmp commands "irq" and "pic" are a bit of a mess. They're implemented
> on a number of targets, but not all. On sparc32 and LM32 they do target
> specific things, but on the remainder (i386, ppc and mips) they call into
> the i8259 PIC code.
>
> But really, what these commands do shouldn't be dependent on the target
> arch, but on the specific machine that's in use. On ppc, for example,
> the "prep" machine usually does have an ISA bridge with an i8259, but
> most of the other machine types have never had an i8259 at all. Similarly
> the sparc specific target would stop working if we ever had a sparc32
> machine that wasn't sun4m.
>
> This patch cleans things up by implementing these hmp commands on all
> targets via a MachineClass callback. If the callback is NULL, for now
> we fallback to target specific defaults that match the existing behaviour.
> The hope is we can remove those later with target specific cleanups.
>
> Signed-off-by: David Gibson <address@hidden>
> ---
> hw/intc/i8259.c | 4 ++--
> include/hw/boards.h | 2 ++
> include/hw/i386/pc.h | 4 ++--
> monitor.c | 57
> ++++++++++++++++++++++++++++++++++++++--------------
> 4 files changed, 48 insertions(+), 19 deletions(-)
This commit message is terribly misleading: Nothing is done wrt
CONFIG_I8259 AFAICT. What about "monitor: Implement info irq and info
pit for all targets"?
The implementation looks fine and once fixed can get a
Reviewed-by: Andreas Färber <address@hidden>
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259,
Andreas Färber <=
Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/6] Remove monitor.c dependency on CONFIG_I8259, Peter Maydell, 2015/03/31
[Qemu-ppc] [PATCH 1/6] Split serial-isa into its own config option, David Gibson, 2015/03/05
[Qemu-ppc] [PATCH 4/6] target-ppc: Convert PReP to machine class, David Gibson, 2015/03/05
[Qemu-ppc] [PATCH 3/6] pc: Use MachineClass callbacks for "irq" and "pic" hmp commands, David Gibson, 2015/03/05
Re: [Qemu-ppc] [PATCH 0/6] Clean up ISA dependencies so we make ISA optional to build, Alexander Graf, 2015/03/06