[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 4/5] powerpc/mpc85xx: Pass 0 flags to board_init_f

From: Alexander Graf
Subject: Re: [Qemu-ppc] [PATCH 4/5] powerpc/mpc85xx: Pass 0 flags to board_init_f
Date: Wed, 30 Apr 2014 19:38:23 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.4.0

On 30.04.14 19:28, York Sun wrote:
On 04/30/2014 10:21 AM, Alexander Graf wrote:
The new generic board_init_f has an argument now that takes a number of
prepopulated gd->flags bits. We don't have any, so let's set this to 0.

Signed-off-by: Alexander Graf <address@hidden>
  arch/powerpc/cpu/mpc85xx/start.S |    1 +
  1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/cpu/mpc85xx/start.S b/arch/powerpc/cpu/mpc85xx/start.S
index 0149146..86883f5 100644
--- a/arch/powerpc/cpu/mpc85xx/start.S
+++ b/arch/powerpc/cpu/mpc85xx/start.S
@@ -1159,6 +1159,7 @@ _start_cont:
bl cpu_init_f
+       li      r3, 0
        bl      board_init_f
I have this patch pending already http://patchwork.ozlabs.org/patch/343618/. I
can take either one when merging.

Ah, sorry, missed that one. The patch is fairly trivial (though debugging it was not - NULL pointer exceptions in printf() are no fun, heh) and you were first, so please just take your patch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]