[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH] linux-user: Fix undefined HOST_LONG_

From: Peter Maydell
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH] linux-user: Fix undefined HOST_LONG_SIZE on PPC hosts
Date: Thu, 19 Apr 2012 15:47:44 +0100

On 19 April 2012 15:23, Alexander Graf <address@hidden> wrote:
> On my PPC host, HOST_LONG_SIZE is not defined even after
> running configure. Use the normal C way of determining the
> long size instead.
>  #elif defined(HOST_PPC)
> -            return HOST_LONG_SIZE;
> +            return sizeof(long);
>  #else

HOST_LONG_SIZE was removed by Stefan in commit 9c6ecf;
it looks like this PPC-only use was accidentally omitted.
For consistency with that commit and how we handle TYPE_LONG
in this function, it would be better to use 'sizeof(void *)'
here I think.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]