[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [Qemu-devel] [PATCH] linux-user: Fix undefined HOST_LONG_

From: Peter Maydell
Subject: Re: [Qemu-ppc] [Qemu-devel] [PATCH] linux-user: Fix undefined HOST_LONG_SIZE on PPC hosts
Date: Thu, 19 Apr 2012 16:55:21 +0100

On 19 April 2012 16:12, Alexander Graf <address@hidden> wrote:
> On 04/19/2012 04:47 PM, Peter Maydell wrote:
>> HOST_LONG_SIZE was removed by Stefan in commit 9c6ecf;
>> it looks like this PPC-only use was accidentally omitted.
>> For consistency with that commit and how we handle TYPE_LONG
>> in this function, it would be better to use 'sizeof(void *)'
>> here I think.
> I'm fairly sure that's not semantically what we're aiming for. We're trying
> to find the host's typdef for the compat_dev_t type.

Actually I think we want __kernel_old_dev_t: TYPE_OLDDEVT is only used
in the loop_info struct. For PPC that's defined here:
as 'unsigned long' on ppc64 and 'unsigned int' on ppc.
And the way thunk.h finds the size of 'unsigned long' on the
host is by sizeof(void*).

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]