[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 1/3] pseries: Fix RTAS based config access

From: Michael S. Tsirkin
Subject: Re: [Qemu-ppc] [PATCH 1/3] pseries: Fix RTAS based config access
Date: Thu, 12 Apr 2012 16:50:46 +0300
User-agent: Mutt/1.5.21 (2010-09-15)

On Thu, Apr 12, 2012 at 02:29:33PM +0200, Andreas Färber wrote:
> Am 02.04.2012 06:17, schrieb David Gibson:
> > On the pseries platform, access to PCI config space is via RTAS calls(
> > which go to the hypervisor) rather than MMIO.  This means we don't use
> > the same code path as nearly everyone else which goes through pci_host.c
> > and we're missing some of the parameter checking along the way.
> > 
> > We do have some parameter checking in the RTAS calls, but it's not enough.
> > It checks for overruns, but does not check for unaligned accesses,
> > oversized accesses (which means the guest could trigger an assertion
> > failure from pci_host_config_{read,write}_common().  Worse it doesn't do
> > the basic checking for the number of RTAS arguments and results before
> > accessing them.
> > 
> > This patch fixes these bugs.
> > 
> > Cc: Michael S. Tsirkin <address@hidden>
> mst, are you planning to review these two patches? The code movements
> and RTAS error handling looks okay to me on brief sight, but I'm no PCI
> expert and the two of you were having discussions as to where to do such
> checks.
> Thanks,
> Andreas

I saw a long argument so I was waiting for dust to settle :)
Will try to review next week.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]