[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 1/3] pseries: Fix RTAS based config access

From: Andreas Färber
Subject: Re: [Qemu-ppc] [PATCH 1/3] pseries: Fix RTAS based config access
Date: Sun, 15 Apr 2012 19:38:20 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0

Am 15.04.2012 12:16, schrieb Michael S. Tsirkin:
> On Mon, Apr 02, 2012 at 02:17:35PM +1000, David Gibson wrote:
>> On the pseries platform, access to PCI config space is via RTAS calls(
>> which go to the hypervisor) rather than MMIO.  This means we don't use
>> the same code path as nearly everyone else which goes through pci_host.c
>> and we're missing some of the parameter checking along the way.
>> We do have some parameter checking in the RTAS calls, but it's not enough.
>> It checks for overruns, but does not check for unaligned accesses,
>> oversized accesses (which means the guest could trigger an assertion
>> failure from pci_host_config_{read,write}_common().  Worse it doesn't do
>> the basic checking for the number of RTAS arguments and results before
>> accessing them.
>> This patch fixes these bugs.
>> Cc: Michael S. Tsirkin <address@hidden>
> No objections from me :) But pls note I have no idea about RTAS.
> Noted a couple of apparent typos below.

Thanks, applied (with typos fixed) to ppc-next:


SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

reply via email to

[Prev in Thread] Current Thread [Next in Thread]